Add the ability to change the nav search background color #404
Conversation
agjohnson
added
the
PR: work in progress
|
See for example https://borgbackup.readthedocs.io/en/stable/ |
ericholscher
left a comment
ericholscher
left a comment
There was a problem hiding this comment.
Looks fine to me, but needs some kind of user facing documentation so that people know it's an option. We should really have a "configuration options" doc.
|
I started working a new docs branch but for now, I am going to add this to the readme |
| 'prev_next_buttons_location': bottom, | ||
| 'style_external_links': False, | ||
| # CSS Options | ||
| 'nav_search_background_color': #2980B9, |
There was a problem hiding this comment.
I guess the # will need to be escaped somehow?
There was a problem hiding this comment.
I think it's just a string in the conf.py directory. Wouldn't it simply be quoted?
|
I'm having some issues testing this and perhaps you could point me in the right direction. Firstly, I don't think you can simply add Based on what I can see since most of the actual overrides are to the saas files wouldn't somebody wanting to use this have to rebuild the theme (with Grunt rather than just making an entry in |
|
After rethinking this I do not like this hack of passing strings around our sass. I think we should remove this sass styling and move it over the a "configurable' CSS file. Does this sound like a better idea? |
To me, yes. I don't think things that can be configured easily with an additional CSS file should be a theme option. |
|
This is now possible with https://sphinx-rtd-theme.readthedocs.io/en/stable/configuring.html#confval-style_nav_header_background In the future, I would like to revisit this to see if its possible to make theme variables affect sass directly. |
There will be changes down in master after this is accepted but for right now I left them out to avoid merge conflicts.